On So, Aug 26, 2012 11:57, John Crispin wrote:

> On 26/08/12 09:58, Edy Corak wrote:
> > This patch updates shorewall6-lite to current stable release 4.5.7
> > 
> > Please note:
> > 
> > The new package shorewall-core 4.5.7 is required by this shorewall-lite 
> > version and perlbase-digest.
> > 
> > Signed-off-by: Edy Corak [email protected]
> 
> Hi,
> 
> 2 things
> * please read the "howto submit patches" howto. the patch has the wrong
> format
> 
> * please turn this into a build variant package
> 
> i will mark both of these as rejected in patchwork.
> 
> John
> _______________________________________________
> openwrt-devel mailing list
> [email protected]
> https://lists.openwrt.org/mailman/listinfo/openwrt-devel

Hi John,

thanks for your notice.

I have read this documentation - Link: 
https://dev.openwrt.org/wiki/SubmittingPatches/Svn

The patch has the same format like all other patches I have submitted before, 
e. g. shorewall6-lite 4.4.22.2 Applied in r28058

Why this patch is now wrong ?

I have tested this patch and it works like expected.

Kind regards

Edy Corak

--
_______________________________________________
openwrt-devel mailing list
[email protected]
https://lists.openwrt.org/mailman/listinfo/openwrt-devel

Reply via email to