Sorry if my previous mail sounded like a command - was not intended. It's all about opinion. I prefer "Do not add issues/mistakes/typos, if you know about them." You decide as its your contribution. And I'm only a contributor myself.
Maddes On 06.09.2012 22:34, Jonh Wendell wrote: > hi! > > before making the patch, I've read https://dev.openwrt.org/ticket/6992 > I decided to go CamelCase to keep the current style and let the change > happen when that bug is fixed. > > makes sense? > > 2012/9/6 Matthias Buecher / Germany <[email protected] > <mailto:[email protected]>> > > Please use lowercase options like all other packages do. > Unfortunately DropBear is one package that has several Camel writings. > I wish that Attitude Adjustment would change this to lower case. > > Maddes > > On 06.09.2012 21:48, Jonh Wendell wrote: > > Once this patch is accepted, I'll update the wiki page > > http://wiki.openwrt.org/doc/uci/dropbear > > > > From 9509ba3a76b014155671cbea72a07caafaf27970 Mon Sep 17 00:00:00 2001 > > From: Jonh Wendell <[email protected] > <mailto:[email protected]> > > <mailto:[email protected] <mailto:[email protected]>>> > > Date: Thu, 6 Sep 2012 16:45:29 -0300 > > Subject: [PATCH] [package] dropbear: Supports IdleTimeout uci config > option > > > > Signed-off-by: Jonh Wendell <[email protected] > <mailto:[email protected]> > > <mailto:[email protected] <mailto:[email protected]>>> > > --- > > package/dropbear/files/dropbear.init | 3 +++ > > 1 file changed, 3 insertions(+) > > > > diff --git a/package/dropbear/files/dropbear.init > > b/package/dropbear/files/dropbear.init > > index c909d28..5c03b32 100755 > > --- a/package/dropbear/files/dropbear.init > > +++ b/package/dropbear/files/dropbear.init > > @@ -81,6 +81,9 @@ dropbear_start() > > [ -f "${val}" ] && append args "-r ${val}" > > config_get val "${section}" dsskeyfile > > [ -f "${val}" ] && append args "-d ${val}" > > + # H) idle timeout > > + config_get val "${section}" IdleTimeout 0 > > + [ "${val}" -ne 0 ] && append args "-I ${val}" > > > > # execute program and return its exit code > > [ "${verbosed}" -ne 0 ] && echo "${initscript}: section ${section} > > starting ${PROG} ${args}" > > -- > > 1.7.9.5 > > > _______________________________________________ > openwrt-devel mailing list > [email protected] <mailto:[email protected]> > https://lists.openwrt.org/mailman/listinfo/openwrt-devel > > > > > -- > Jonh Wendell > http://www.bani.com.br > > > > _______________________________________________ > openwrt-devel mailing list > [email protected] > https://lists.openwrt.org/mailman/listinfo/openwrt-devel > Matthias "Maddes" Bücher -- http://www.maddes.net/ Home: Earth / Germany / Ruhr-Area _______________________________________________ openwrt-devel mailing list [email protected] https://lists.openwrt.org/mailman/listinfo/openwrt-devel
