Hi,

On 24 July 2012 02:43, Álvaro Fernández Rojas <[email protected]> wrote:
> Add 963281T_TEF board support (wlan BCM43225).
> Flash size is 16M.
>
> Signed-off-by: Álvaro Fernández Rojas <[email protected]>

This patch looks good, but does not apply to trunk anymore, can you
please resend it?

Also some small comments:
>
> Index: target/linux/brcm63xx/image/Makefile
> ===================================================================
> --- target/linux/brcm63xx/image/Makefile        (revisión: 32704)
> +++ target/linux/brcm63xx/image/Makefile        (copia de trabajo)

Please create your patch so it applies with -p1 - you can do that if
you create the patch from the parent directory of your checkout. E.g.
if you checked it out to ~/openwrt/trunk, then you run
~/openwrt# svn diff trunk/
and it should create an appropriate patch.

> @@ -151,6 +151,7 @@
>         $(call 
> Image/Build/CFE,$(1),963281TAN,6328,963481TAN-4M-flash-generic,,--pad 2)
>         $(call 
> Image/Build/CFE,$(1),963281TAN,6328,963481TAN-8M-flash-generic,,--pad 4)
>         $(call 
> Image/Build/CFE,$(1),963281TAN,6328,963481TAN-16M-flash-generic,,--pad 8)
> +       $(call 
> Image/Build/CFE,$(1),963281T_TEF,6328,963281T_TEF-generic,,--pad 8)
>         $(call Image/Build/CFE,$(1),96345GW2,6345,96345GW2-generic)
>         $(call Image/Build/CFE,$(1),96345GW2,6345,96348GW2-bc221,,--layoutver 
> 5)
>         $(call 
> Image/Build/CFE,$(1),96345GW2,6345,92345GW2-rev,OpenWRT-$(REVISION))
> Index: target/linux/brcm63xx/patches-3.3/902-board-963281T_TEF.patch
> ===================================================================
> --- target/linux/brcm63xx/patches-3.3/902-board-963281T_TEF.patch       
> (revisión: 0)
> +++ target/linux/brcm63xx/patches-3.3/902-board-963281T_TEF.patch       
> (revisión: 0)

Please use the next free number after 500. We try to keep the board
patches grouped at 500+.


Jonas
_______________________________________________
openwrt-devel mailing list
[email protected]
https://lists.openwrt.org/mailman/listinfo/openwrt-devel

Reply via email to