Hi,

On 25 October 2012 09:52, [email protected]
<[email protected]> wrote:
> From: Bernd Krumböck <krumboeck_at_universalnet.at>
>
> Update CUPS to 1.5.4 and package client, libs, filters, locales and daemon
> to
> separate packages. Replace makefile-targets patch with components patch.
> Fix ppdc patch.
> Based on cups-1.4.4 (backfire)
>
> Signed-off-by: Bernd Krumböck <krumboeck_at_universalnet.at>

Looks better, but that's still not a valid signed-off-by :P

Some further comments:

Patches should be based on trunk or packages, not any branches (fixes
should always go into trunk first, then backported).

> ---
>  Makefile                           |  572
> ++++++++++++++++++++++++++++++++++++-
>  patches/100-components.patch       |   42 +++
>  patches/100-makefile-targets.patch |   13 -
>  patches/160-ppdc.patch             |    8
>  patches/200-str4181.patch          |   13 +
>  patches/210-str4194.patch          |   11 +
>  6 files changed, 625 insertions(+), 34 deletions(-)
>
> --- a/package/feeds/packages/cups/Makefile      2012-10-05

This isn't the correct location, it should be based on the actual
repository, so it should be

a/net/cups/Makefile


Jonas
_______________________________________________
openwrt-devel mailing list
[email protected]
https://lists.openwrt.org/mailman/listinfo/openwrt-devel

Reply via email to