On Wed, Dec 05, 2012 at 12:00:14PM +0100, Helmut Schaa wrote: > On Tue, Dec 4, 2012 at 10:39 PM, Antonio Quartulli <[email protected]> > wrote: > > On Tue, Dec 04, 2012 at 10:05:10PM +0100, Helmut Schaa wrote: > >> Hi, > >> > >> On Tue, Dec 4, 2012 at 5:23 PM, Antonio Quartulli <[email protected]> > >> wrote: > >> > This is in mac80211_hostapd_setup_base() which is invoked in > >> > mac80211_hostapd_setup_bss() that is already invoked per-vif. > >> > > >> > So I don't think this change was really needed. > >> > >> From mac80211.sh: > >> > >> 138 if [ -f "$cfgfile" ]; then > >> 139 append hostapd_cfg "bss=$ifname" "$N" > >> 140 else > >> 141 mac80211_hostapd_setup_base "$phy" "$ifname" > >> 142 append hostapd_cfg "interface=$ifname" "$N" > >> 143 fi > >> > >> So mac80211_hostapd_setup_base is only called for the first vif and thus > >> only > >> macfilter on the first vif can be configured. > > > > This code you posted here is taken from mac80211_hostapd_setup_bss(). If we > > go > > at mac80211.sh:427 you see > > > > 427 for vif in $vifs; do > > 428 config_get mode "$vif" mode > > 429 [ "$mode" = "ap" ] || continue > > 430 mac80211_hostapd_setup_bss "$phy" "$vif" > > 431 start_hostapd=1 > > 432 done > > > > So the scripts execute the code you posted for each vif. Am I missing > > something? > > No, it gets only executed once, check the snippet again; > > if [ -f "$cfgfile" ]; then
Thanks for pointing this out. Looking at this snippet I can clearly see that you are right. And now the puzzle starts: why is it working here? We are already using this code and it seems to be working as expected...I'm concerned about some hidden stuff somewhere else. Did you hit any problem? Is this why you sent this patch? Thank you very much. Cheers, -- Antonio Quartulli ..each of us alone is worth nothing.. Ernesto "Che" Guevara
pgpsP5nnG75xp.pgp
Description: PGP signature
_______________________________________________ openwrt-devel mailing list [email protected] https://lists.openwrt.org/mailman/listinfo/openwrt-devel
