On 13-01-04 04:23 PM, Damian Kaczkowski wrote:
On 4 January 2013 21:52, Damian Kaczkowski <damian.kaczkow...@gmail.com>wrote:
On 4 January 2013 18:25, Bastian Bittorf <bitt...@bluebottle.com> wrote:
- MKSWAP and SWAPONOFF has to be a dependency, the old package compcache
does this via
DEPENDS:=@BUSYBOX_CONFIG_SWAPONOFF @BUSYBOX_CONFIG_MKSWAP
I think better dependency would be:
define KernelPackage/zram/config
select BUSYBOX_CONFIG_MKSWAP if !PACKAGE_swap-utils
select BUSYBOX_CONFIG_SWAPONOFF if !PACKAGE_swap-utils
endef
btw. Do we really need dependency for mkswap / swaponoff ? You can use any
fs on zram disk not only swap (also your init script already checks for
mkswap and swapon bins (but not swapoff btw.)). Maybe better would be what
hauke proposed? - just set CONFIG_BUSYBOX_CONFIG_MKSWAP=y,
CONFIG_BUSYBOX_CONFIG_SWAPONOFF=y as default config. Then also some other
packages might benefit from this, eg. block-mount
Actually swaponoff and mkswap were ditched by default due to size
(block-mount is an optional package). Also depends that change busybox
configuration are considered bad and it was an error to have them before
(it creates incompatible bb builds depending on what packages are
built). Better only have the util-linux dependency (if it's even needed).
--
Daniel Dickinson PowerCloud Systems, Palo Alto, CA Senior Firmware
Engineer (In Canada: Senior Firmware Analyst)
_______________________________________________
openwrt-devel mailing list
openwrt-devel@lists.openwrt.org
https://lists.openwrt.org/mailman/listinfo/openwrt-devel
