Cezary Jackiewicz <[email protected]> writes: > +define Profile/3G300M > + NAME:=Tenda 3G300M > + PACKAGES:=\ > + kmod-usb-core kmod-usb-rt305x-dwc_otg \ > + kmod-ledtrig-usbdev > +endef
What is the motivation to have a dedicated profile that's exactly the same as the default one? > +define BuildFirmware/3G300M > + $(call BuildFirmware/Generic,$(1),$(2),$(call mkcmdline,$(3),$(4),$(5)) > $(call mkmtd/$(6),$(mtdlayout_4M)),917504,2949120) > + mkimage -A mips -O linux -T kernel -C lzma $(call kernel_entry) \ > + -n "3G150M_SPI Kernel Image" \ > + -d "$(KDIR)/vmlinux-$(2).bin.lzma" \ > + "$(KDIR)/vmlinux-$(2).uImage" > + $(call > CatFiles,$(KDIR)/vmlinux-$(2).uImage,917504,$(KDIR)/root.$(1),2949120,$(call > imgname,$(1),$(2))-factory.bin) > +endef Can you please take a look at http://patchwork.openwrt.org/patch/3132/ , do you know of any reason do not do it the same way here? BTW, do you think kernel_size_4M and rootfs_size_4M should be defined and used for all the mtdlayout_4M targets instead of hardcoding those numbers? -- Be free, use free (http://www.gnu.org/philosophy/free-sw.html) software! mailto:[email protected] _______________________________________________ openwrt-devel mailing list [email protected] https://lists.openwrt.org/mailman/listinfo/openwrt-devel
