On 19 February 2013 16:17, Rafał Miłecki <[email protected]> wrote: > Setting this bit stops BCM53125 (bgmac actually) from receiving any > packets. In theory setting "managed" mode makes sense when enabling VLAN > (at least for me?) but for some reason it breaks configuration. > > This bit is cleared in b53_switch_reset and it seems the same is done in > bcmrobo.c which never sets that bit again.
The bit is a bit misnamed, it doesn't enable management per se but actually enables special treatment for the CPU port and certain ethernet frames (IIRC multicast joins/leaves etc). It's probably fine to keep it disabled until we want to use multicast snooping or 802.1x authentication (which IIRC require this to allow "trap to CPU" to work), or want to implement open vswitch support (as if ;-). Jonas > > Signed-off-by: Rafał Miłecki <[email protected]> > --- > I'm not sure about clearing SM_SW_FWD_MODE bit in the "else" inside of > b53_enable_vlan. Should be drop that too? Probably just clear it unconditionally. I need to make sure first it doesn't break 5325 or 53115. > --- > target/linux/generic/files/drivers/net/phy/b53/b53_common.c | 3 --- > 1 file changed, 3 deletions(-) > > diff --git a/target/linux/generic/files/drivers/net/phy/b53/b53_common.c > b/target/linux/generic/files/drivers/net/phy/b53/b53_common.c > index 923d155..f992118 100644 > --- a/target/linux/generic/files/drivers/net/phy/b53/b53_common.c > +++ b/target/linux/generic/files/drivers/net/phy/b53/b53_common.c > @@ -245,9 +245,6 @@ static void b53_enable_vlan(struct b53_device *dev, int > enable) > } > > if (enable) { > - if (!is63xx(dev)) > - mgmt |= SM_SW_FWD_MODE; > - > vc0 |= VC0_VLAN_EN | VC0_VID_CHK_EN | VC0_VID_HASH_VID; > vc1 |= VC1_RX_MCST_UNTAG_EN | VC1_RX_MCST_FWD_EN; > vc4 &= ~VC4_ING_VID_CHECK_MASK; > -- > 1.7.10.4 > > _______________________________________________ > openwrt-devel mailing list > [email protected] > https://lists.openwrt.org/mailman/listinfo/openwrt-devel _______________________________________________ openwrt-devel mailing list [email protected] https://lists.openwrt.org/mailman/listinfo/openwrt-devel
