2013.03.11. 20:57 keltezéssel, Felix Fietkau írta: > On 2013-03-11 7:58 PM, Petr Štetiar wrote: >> Petr Štetiar <[email protected]> [2013-03-10 21:21:04]: >> >>> Felix Fietkau <[email protected]> [2013-03-10 15:37:41]: >>> >>>> Does reverting this change make things work for you in the latest revision? >>> >>> Yes, I did reverted it in AA and it works fine: >>> >>> 89b3ea101c0a49194d637a119bccea6ae47ae2c3 Revert "AA: ar71xx: fix GPIO >>> function selection for AR934x" >>> 9fbae55e5eba290bdf4fa47ad75c998da9d4931e ar71xx: enable building >>> ramdisk images for WZRHPG30XNH board types >>> 4577d9d123ae4ca097c75f5ce2f4344ce67b2074 AA: hotplug2: restore >>> accidentally deleted patch >>> ... >> >> This call in om2p_hs_setup() is causing this: >> >> ath79_gpio_function_enable(AR933X_GPIO_FUNC_JTAG_DISABLE); > Interesting. The commit enabled access to the gpio function register for > AR934x, but that register has a different layout than the ones on older > chips. This line of code (which previously did nothing, as it touched > the wrong register) sets a bit that maps to a 'reserved' flag according > to hardware documentation. > As a quick fix we can just get rid of the line (it never did anything > useful anyway), and then we should probably check if the GPIO function > register access should be common for AR934x and pre-AR934x at all, given > that they don't seem to have much in common. > Maybe Gabor (Cc'd) has an opinion on that... > Thanks for tracking this down.
Basically, the purpose of the GPIO function register access is to be able to set/clear a bit in that register. In this regard it is common for all SoCs. Maybe it would be better to customize it for each SoC with proper pinmux drivers. Until that is done the current method can be used even if it is not perfect. BTW, I have fixed the OM2P-HS setup code to use the correct bitmast a few minutes ago: https://dev.openwrt.org/changeset/35965 https://dev.openwrt.org/changeset/35966 -Gabor _______________________________________________ openwrt-devel mailing list [email protected] https://lists.openwrt.org/mailman/listinfo/openwrt-devel
