Le samedi 23 mars 2013 00:21:38, John Szakmeister a écrit : > On Thu, Feb 28, 2013 at 5:03 AM, John Szakmeister <[email protected]> wrote: > > It turns out that the symlink may exists already by the time the > > toolchain Makefile gets an opportunity to run. While we asked to > > replace the target, ln doesn't do so until after dereferencing the > > existing symlink. This results in an unintended symlink that refers to > > itself. Instead, create the link without dereferencing any > > symlinks by using the -n option. > > --- > > > > While this is the only instance that's actually causing a bad link to be > > created, there are a couple of other spots that intend to symlink > > directories that aren't using the -n option. Should those be updated > > too? > > Ping. I just wanted to see if there's any feedback on this, or > something else I need to do to get this applied. It's not critical, > but it's nice. And I'm trying to get my feet wet for some future > submissions.
Sounds like a valid fix. Can you resubmit with a Signed-off-by tag as described here: https://dev.openwrt.org/wiki/SubmittingPatches? Thanks! -- Florian _______________________________________________ openwrt-devel mailing list [email protected] https://lists.openwrt.org/mailman/listinfo/openwrt-devel
