On 2013-05-14 3:06 PM, Andrew McDonnell wrote: > Hi Felix, > > I am trying to port the DIR-632-A1 and made the most progress fixing the > ag71xx to work on this board by following what the (working but differently > architectured) DD-WRT driver for the AG7240 does. It sets ring sizes that are > different from the defaults provided by OPenWRT. This was one of the changes > I made early on before I finally got eth0 working, so it is possibly > redundant, but I figured the developers chose those values for a reason and > they work for me... Right, the problem with that line of thinking is that sometimes things are done in a particular way for no good reason :)
> Is the above too verbose? :-) It's fine, but my recommendation stands: With every change that you make in your patch submissions, you have to either have a reason for it, or have explicitly tested if it makes a difference or not. > Note, I am still gaining experience workng with Linux kernel ethernet drivers, > so I dont deeply understand some of the code, but I am following proven > working software and testing by transferring multiple large files. Sounds good. - Felix _______________________________________________ openwrt-devel mailing list [email protected] https://lists.openwrt.org/mailman/listinfo/openwrt-devel
