On Fri, 2013-05-24 at 15:17 +0200, John Crispin wrote: > Hi, > > few comments > > * the patches are against the wrong base directory
The patches are against trunk. Should they not be? > * the descriptions are undescriptives Yes, I already know documentation is not a forte of mine. I tried my best. > * please make sure that each patch only holds one change. a quick look > told me, that they hold more > > John Patch #1 has only one change, from "make kernel_menuconfig" updated from the file simply copied from the 3.7 config. Patch #2 has one change in two files, and a closely related change in a third file. Patch #3 has a single change, applicable across three files. Patch #4 is the big one. It patches the 0037 patchfile in the patches-3.8 directory, containing many changes, but it's largely atomic because the 0037 patchfile itself contains many changes which, as I said in the description, would be more manageable if it were itself separated into multiple patchfiles. Patch #5 is relatively trivial altogether. _______________________________________________ openwrt-devel mailing list [email protected] https://lists.openwrt.org/mailman/listinfo/openwrt-devel
