Hi, Zhiqiang

On Wed, Jul 03, 2013 at 08:44:44AM +0800, zhiqiang wang wrote:
> Signed-off-by: Zhiqiang Wang <[email protected]>
> ---

<snip>

> --- target/linux/ar71xx/patches-3.8/610-MIPS-ath79-openwrt-machines.patch
> (revision
> 37128)
> +++ target/linux/ar71xx/patches-3.8/610-MIPS-ath79-openwrt-machines.patch
> (working
> copy)

<snip>

> @@ -516,7 +517,7 @@
>  + select ATH79_DEV_M25P80
>  +
>  +config ATH79_MACH_TL_MR11U
> -+ bool "TP-LINK TL-MR11U/TL-MR3040 support"
> ++ bool "TP-LINK TL-MR11U/TP-LINK TL-MR13U/TL-MR3040 support"

This line and a line below ...

>  + select SOC_AR933X
>  + select ATH79_DEV_ETH
>  + select ATH79_DEV_GPIO_BUTTONS
> ---
> target/linux/ar71xx/patches-3.8/620-MIPS-ath79-add-Archer-C7-support.patch
> (revision
> 37128)
> +++
> target/linux/ar71xx/patches-3.8/620-MIPS-ath79-add-Archer-C7-support.patch
> (working
> copy)
> @@ -15,7 +15,7 @@
>  + select ATH79_DEV_WMAC
>  +
>   config ATH79_MACH_TL_MR11U
> - bool "TP-LINK TL-MR11U/TL-MR3040 support"
> + bool "TP-LINK TL-MR11U/TL-MR13U/TL-MR3040 support"

Here. They doesn't match, so the patch may not apply cleanly.

>   select SOC_AR933X
>  --- a/arch/mips/ath79/machtypes.h
>  +++ b/arch/mips/ath79/machtypes.h
> --- target/linux/ar71xx/files/arch/mips/ath79/mach-tl-mr11u.c (revision
> 37128)
> +++ target/linux/ar71xx/files/arch/mips/ath79/mach-tl-mr11u.c (working copy)
> @@ -1,5 +1,5 @@
>  /*
> - *  TP-LINK TL-MR11U/TL-MR3040 board support
> + *  TP-LINK TL-MR11U/TL-MR3040/TL-MR13U board support

Alphabetical order like `TP-LINK TL-MR11U/TL-MR13U/TL-MR3040` should be better.

>   *
>   *  Copyright (C) 2011 dongyuqi <[email protected]>
>   *  Copyright (C) 2011-2012 Gabor Juhos <[email protected]>
> @@ -32,6 +32,7 @@
> 
>  #define TL_MR11U_GPIO_USB_POWER 8
>  #define TL_MR3040_GPIO_USB_POWER 18
> +#define TL_MR13U_GPIO_USB_POWER 18

Also here.

> 
>  #define TL_MR11U_KEYS_POLL_INTERVAL 20 /* msecs */
>  #define TL_MR11U_KEYS_DEBOUNCE_INTERVAL (3 * TL_MR11U_KEYS_POLL_INTERVAL)
> @@ -136,3 +137,18 @@
> 
>  MIPS_MACHINE(ATH79_MACH_TL_MR3040, "TL-MR3040", "TP-LINK TL-MR3040",
>       tl_mr3040_setup);
> +
> +static void __init tl_mr13u_setup(void)
> +{
> +        common_setup();
> +
> +        ath79_register_gpio_keys_polled(-1, TL_MR11U_KEYS_POLL_INTERVAL,
> +                                        1, tl_mr11u_gpio_keys);
> +        gpio_request_one(TL_MR13U_GPIO_USB_POWER,
> +                         GPIOF_OUT_INIT_HIGH | GPIOF_EXPORT_DIR_FIXED,
> +                         "USB power");
> +}
> +
> +MIPS_MACHINE(ATH79_MACH_TL_MR13U, "TL-MR13U", "TP-LINK TL-MR13U",
> +             tl_mr13u_setup);
> +

Plaintext emails are preferred for patch submission. I don't have
a device of this model, but this patch is corrupted in that tabs in the
source code were replaced with blank spaces and long lines were wrapped.
Wiki page for SubmittingPatches [1] should help.

[1] https://dev.openwrt.org/wiki/SubmittingPatches


Regards!
--
yousong
_______________________________________________
openwrt-devel mailing list
[email protected]
https://lists.openwrt.org/mailman/listinfo/openwrt-devel

Reply via email to