On Mon, Jul 22, 2013 at 9:38 PM, John Crispin <[email protected]> wrote: > On 22/07/13 21:37, [email protected] wrote: >> >> Here's a photo - you can see how it is a module mounted on a baseboard. >> http://www.ayyari.com/pic/AYYAR.jpg > > > these 2 file have essentially the same info in them which made me wonder, > but i understand now why this is so ... > > target/linux/ramips/dts/AWM002-EVB-4M.dts > target/linux/ramips/dts/AWM002-EVB-8M.dts > > > i am not really happy with having 5 dts files to essentially describe one > biard, but unless i can come up with a better solution tomorrow i will merge > the patch as is.
Since both are identical except for the part they include, everything in them could be moved into the "top" dtsi, and the dtsi files with the flashchip made to .dts. Also somehow the one other thing that should be different between the two versions, the firmware partion's size, is defined for the top .dtsi; that one should actually be in the .dts files. Looking at it, it is defined as ~32 MiB, so there is some reliance on the kernel doing the right thing and shrinking it to the right size. And if we are doing that, then there is no reason at all anymore for having different dtsi files, as we can then also use m25p80's ability to autodetect the flash chip and get rid of the dual size thingy. Regards Jonas _______________________________________________ openwrt-devel mailing list [email protected] https://lists.openwrt.org/cgi-bin/mailman/listinfo/openwrt-devel
