On Thu, Sep 5, 2013 at 2:46 AM, Felix Fietkau <[email protected]> wrote: > On 2013-09-04 7:37 PM, Luis R. Rodriguez wrote: >> On Thu, Aug 29, 2013 at 06:12:02PM +0200, Felix Fietkau wrote: >>> On 2013-08-28 10:30 PM, Luis R. Rodriguez wrote: >>> > From: "Luis R. Rodriguez" <[email protected]> >>> > >>> > The mac80211.sh script uses readlink -f which requires >>> > >>> > CONFIG_BUSYBOX_CONFIG_READLINK >>> > CONFIG_BUSYBOX_CONFIG_FEATURE_READLINK_FOLLOW >>> > >>> > Without these wifi detect will fail and users end up >>> > puzzled with error messages such as: >>> > >>> > PHY for wifi device radio0 not found >>> > >>> > This is due to the fact that without these options >>> > mac80211.sh readlink -f command will fail and not >>> > assign the appropriate phy for the devices. This >>> > fixes initial configuration with OpenWrt with the >>> > as 'wifi detect > /etc/config/wireless' depends on >>> > mac80211.sh. >>> > >>> > Cc: Kalle Valo <[email protected]> >>> > Cc: Kathy Giori <[email protected]> >>> > Cc: Mathieu Olivari <[email protected]> >>> > Cc: Jerome Proffit <[email protected]> >>> > Cc: Sujith Manoharan <[email protected]> >>> > Cc: Matthew McClintock <[email protected]> >>> > Signed-off-by: Luis R. Rodriguez <[email protected]> >>> NACK. readlink is enabled by default in the busybox config, and it's >>> needed by other things as well, including base-files (rc.common). >>> Adding these dependencies to the mac80211 package thus seems a bit >>> arbitrary and out of place. >>> I think at some point it probably makes sense to remove the top-level >>> busybox menuconfig integration and treat its configuration more like >>> kernel_menuconfig. >> >> Does it also enable by default BUSYBOX_CONFIG_FEATURE_READLINK_FOLLOW ? >> At least on AA it does not seem like so. > I just fixed that, as of r37896 it gets enabled by default.
Thanks, odd though I don't see that on the git tree [0], I see r37897 and r37895 but not r37896. Is this in another tree perhaps? git://nbd.name/openwrt.git Luis _______________________________________________ openwrt-devel mailing list [email protected] https://lists.openwrt.org/cgi-bin/mailman/listinfo/openwrt-devel
