Hi,
On Thu, Sep 5, 2013 at 12:28 PM, <[email protected]> wrote:
> Added Asmax AR 1004g router
>
> Signed-off-by: Adrian Feliks <[email protected]>
>
> ----------------------------------------------------------------------------------
>
> --- a/arch/mips/bcm63xx/boards/board_bcm963xx.c
> +++ b/arch/mips/bcm63xx/boards/board_bcm963xx.c
This needs to be a patch creating a kernel patch, not the kernel patch directly.
> @@ -67,7 +67,6 @@
> #define CT6373_SPI_GPIO_CLK 6
> #define CT6373_74HC64_GPIO(X) (CT6373_74X164_GPIO_BASE + (X))
>
> -
> static struct board_info board;
>
> /*
Unrelated whitespace change, please drop that part.
> @@ -1915,6 +1914,50 @@ static struct board_info __initdata boar
> },
> };
>
> +static struct board_info __initdata board_96348gw_10_AR1004G = {
> + .name = "AR1004G",
> + .expected_cpu_id = 0x6348,
> +
> + .has_uart0 = 1,
> + .has_enet1 = 1,
> +
> + .enet1 = {
> + .has_phy = 1,
> + .phy_id = 0,
> + .force_speed_100 = 1,
> + .force_duplex_full = 1,
> + },
> +
> + .leds = {
> + {
> + .name = "AR1004G:green:inet",
> + .gpio = 3,
> + .active_low = 1,
> + },
> + {
> + .name = "AR1004G:green:power",
> + .gpio = 0,
> + .active_low = 1,
> + },
> + {
> + .name = "AR1004G:red:power",
> + .gpio = 6,
> + .active_low = 1,
> + },
> + },
> +
> + .buttons = {
> + {
> + .desc = "reset",
> + .gpio = 33,
> + .active_low = 1,
> + .type = EV_KEY,
> + .code = KEY_RESTART,
> + .debounce_interval = BCM963XX_KEYS_DEBOUNCE_INTERVAL,
> + },
> + },
> +};
> +
> #endif
>
> /*
> @@ -4075,6 +4118,7 @@ static const struct board_info __initcon
> &board_96348A_122,
> &board_CPVA502plus,
> &board_96348W3,
> + &board_96348gw_10_AR1004G,
> #endif
>
> #ifdef CONFIG_BCM63XX_CPU_6358
>
>
> diff --git a/target/linux/brcm63xx/base-files/etc/uci-defaults/02_network
> b/target/linux/brcm63xx/base-files/etc/uci-defaults/02_network
> index d7f6c3a..d71f337 100755
> --- a/target/linux/brcm63xx/base-files/etc/uci-defaults/02_network
> +++ b/target/linux/brcm63xx/base-files/etc/uci-defaults/02_network
> @@ -34,7 +34,8 @@ CT6373-1 |\
> D-4P-W |\
> "F@ST2604" |\
> RTA1320_16M |\
> -V2110)
> +V2110 |\
> +AR1004G)
Please try to keep the alphabetical order (even if it isn't 100%)
> ucidef_set_interface_lan "eth0"
> ucidef_add_switch "eth0" "1" "1"
> ucidef_add_switch_vlan "eth0" "1" "0 1 2 3 4 5"
Does vlan tagging work? If yes, please chose the one where the cpu
port is tagged (5t); this makes subsequent switch configuration
easier. If not, then there is no reason for configuring the switch.
> diff --git a/target/linux/brcm63xx/base-files/lib/brcm63xx.sh
> b/target/linux/brcm63xx/base-files/lib/brcm63xx.sh
> index 7c449ae..ad05853 100755
> --- a/target/linux/brcm63xx/base-files/lib/brcm63xx.sh
> +++ b/target/linux/brcm63xx/base-files/lib/brcm63xx.sh
> @@ -121,6 +121,10 @@ brcm63xx_detect() {
> brcm63xx_has_reset_button="true"
> ifname=eth0
> ;;
> + AR1004G)
> + status_led="AR1004G:green:power"
> + brcm63xx_has_reset_button="true"
> + ;;
Same here, please try to keep the alphabetical order.
> *)
> ;;
> esac
> diff --git a/target/linux/brcm63xx/image/Makefile
> b/target/linux/brcm63xx/image/Makefile
> index dc11c33..79f1fb8 100755
> --- a/target/linux/brcm63xx/image/Makefile
> +++ b/target/linux/brcm63xx/image/Makefile
> @@ -289,6 +289,9 @@ define Image/Build
> # Netgear CVG834G
> $(call Image/Build/HCS,$(1),cvg834g,a020,0001,0022,$(KDIR)/vmlinux)
>
> + # Asmax AR 1004g
> + $(call Image/Build/CFEFIXUP,$(1),96348GW-10,AR1004G,6348,AR1004G)
> +
> ifeq ($(CONFIG_TARGET_ROOTFS_INITRAMFS),y)
> $(call Image/Build/Initramfs)
> endif
Apart from those issues the patch looks okay. Please fix and resubmit.
Regards
Jonas
_______________________________________________
openwrt-devel mailing list
[email protected]
https://lists.openwrt.org/cgi-bin/mailman/listinfo/openwrt-devel
