19.09.13, 20:59, Gabor Juhos пишет: > 2013.09.13. 12:55 keltezéssel, Dirk Neukirchen írta: >> On 01.09.2013 20:14, Gabor Juhos wrote: >>> >>> Yes, it is necessary. The coding style of the mach-wnr2200.c file is >>> horrible: >>> >>> >>> Additionally, a board specific patch is missing from >>> 'target/linux/ar71xx/patches-3.10'. >>> >>> Thanks, >>> Gabor >>> >>> >> >> I didn't have time earlier but here is v2. >> >> checkpatch warns about line length on 2 occasions but >> I don't think that breaking that line is really necessary >> >> I don't have a WNR2200 so I cannot test but it compiles. >> >> Some gpio is from dd-wrt but i left that commented out >> >> Changes: >> - fixed comments >> - fixed indentation >> - WNR220_GPIO_USB_POWER -> WNR2200_GPIO_USB_POWER >> - add linux/gpio.h dependency >> - comment out gpio stuff from dd-wrt for now >> >> >> Signed-off-by: Dirk Neukirchen <dirkneukirc...@web.de> > > Applied with some changes. > > Thanks, > Gabor > _______________________________________________ > openwrt-devel mailing list > openwrt-devel@lists.openwrt.org > https://lists.openwrt.org/cgi-bin/mailman/listinfo/openwrt-devel
There are some small mistakes I found: 1) target/linux/ar71xx/base-files/etc/diag.sh, line 179 Shouldn't the LED be green instead of the amber one? In other devices it is. 2) target/linux/ar71xx/files/arch/mips/ath79/mach-wnr2200.c, line 95 Typo, it says "anber", should be "amber" Best regards, Roman A. aka BasicXP x12ozmo...@ya.ru
signature.asc
Description: OpenPGP digital signature
_______________________________________________ openwrt-devel mailing list openwrt-devel@lists.openwrt.org https://lists.openwrt.org/cgi-bin/mailman/listinfo/openwrt-devel
