On Fri, Sep 20, 2013 at 06:46:32PM +0200, Gabor Juhos wrote:
> Hi Sebastian,
> 
> Please use the 'ar71xx:' prefix instead of [ar71xx] in the subject of ar71xx
> specific patches.
> 
> > Hello list,
> 
> Please don't use salutation part in patches. Everything before the marker line
> '---' will be included into the commit message, so I have to remove this line
> manually before applying the patch.
> 
> > This patch removes the custom LAN LED configuration for the switch.
> > Without it the LAN LEDs are actually working.
> > 
> > I also tried the same configuration that is used in mach-db120.c. That
> > worked as well. But I think why add it when it's not needed.
> 
> I would fix it instead. It would make it independent from the bootloader.
> 
> > 
> > Signed-off-by: Sebastian Kemper <[email protected]>
> 
> The marker line '---' is missing.
> 
> -Gabor

Hello Gabor,

OK, thanks for the hints. I'll send a new round of patches in a short
while.

Kind regards,
Sebastian
_______________________________________________
openwrt-devel mailing list
[email protected]
https://lists.openwrt.org/cgi-bin/mailman/listinfo/openwrt-devel

Reply via email to