Hi Sven,
thank you for addressing that issue!
On 10/17/2013 06:42 PM, Sven Eckelmann wrote:
> diff --git a/target/linux/ar71xx/base-files/lib/upgrade/allnet.sh
> b/target/linux/ar71xx/base-files/lib/upgrade/allnet.sh
> index 9a375ff..8076fbd 100644
> --- a/target/linux/ar71xx/base-files/lib/upgrade/allnet.sh
> +++ b/target/linux/ar71xx/base-files/lib/upgrade/allnet.sh
> @@ -7,6 +7,7 @@
> platform_add_ramfs_ubootenv() {
> [ -e /usr/sbin/fw_printenv ] && install_bin /usr/sbin/fw_printenv
> /usr/sbin/fw_setenv
> [ -e /etc/fw_env.config ] && install_file /etc/fw_env.config
> + [ -e /bin/mkdir ] && install_bin /bin/mkdir /bin/mkdir
mkdir is a link to busybox. wouldn't it be better to just add that symlink to
the list of busybox symlinks in
/package/base-files/files/lib/upgrade/common.sh
or even better: why not just
mkdir -p $RAM_ROOT/var/lock
and not even use mkdir inside the ramdisk?
> }
> append sysupgrade_pre_upgrade platform_add_ramfs_ubootenv
>
> @@ -151,6 +152,10 @@ rootfs_size $rootfs_hexsize
> rootfs_checksum $rootfs_md5
> bootcmd bootm $vmlinux_hexaddr
> EOF
> +
> + # fw_setenv needs the lock /var/lock/fw_setenv.lock
> + mkdir -p /var/lock/
> +
This part would then be unneeded if $RAM_ROOT/var/lock is created before
chroot'ing into the ramdisk.
> fw_setenv -s /tmp/fw_env_upgrade || {
> echo "failed to update U-Boot environment"
> return 1
> diff --git a/target/linux/ar71xx/base-files/lib/upgrade/openmesh.sh
> b/target/linux/ar71xx/base-files/lib/upgrade/openmesh.sh
> index 5179875..7b82180 100644
> --- a/target/linux/ar71xx/base-files/lib/upgrade/openmesh.sh
> +++ b/target/linux/ar71xx/base-files/lib/upgrade/openmesh.sh
Same applies here, of course.
Cheers
Daniel
_______________________________________________
openwrt-devel mailing list
[email protected]
https://lists.openwrt.org/cgi-bin/mailman/listinfo/openwrt-devel
