Regarding data presentation in Luci-statistics, there are three changes requiring patches to Luci feed:

-conntrack result data has changed name from "entropy" to "value".
-ping result data has changed name from "ping" to "value".
http://git.verplant.org/?p=collectd.git;a=commitdiff;h=77a6905147798210ec17173bd5e4410adcc3a112

-interface plugin has changed rrd data file structure so that the plugin instances (=interfaces) have separate data files. Luci needs to draw the graph for each plugin instance, not for each data instance. http://git.verplant.org/?p=collectd.git;a=commitdiff;h=cc3640ba512862cd5745446f1f1a997dd4344454

Signed-off-by: Hannu Nyman <[email protected]>

--- 
luci/trunk/applications/luci-statistics/luasrc/statistics/rrdtool/definitions/conntrack.lua
 (revision 9920)
+++ 
luci/trunk/applications/luci-statistics/luasrc/statistics/rrdtool/definitions/conntrack.lua
 (working copy)
@@ -22,7 +22,7 @@
                number_format = "%5.0lf",
                data = {
                        sources = {
-                               conntrack = { "entropy" }
+                               conntrack = { "value" }
                        },
                        options = {
                                conntrack = { 
--- 
luci/trunk/applications/luci-statistics/luasrc/statistics/rrdtool/definitions/interface.lua
 (revision 9920)
+++ 
luci/trunk/applications/luci-statistics/luasrc/statistics/rrdtool/definitions/interface.lua
 (working copy)
@@ -22,9 +22,9 @@
        --
        local traffic = {
 
-               -- draw this diagram for each data instance
+               -- draw this diagram for each plugin instance
                per_instance = true,
-               title = "%H: Transfer on %di",
+               title = "%H: Transfer on %pi",
                vlabel = "Bytes/s",
 
                -- diagram data description
@@ -58,9 +58,9 @@
        --
        local packets = {
 
-               -- draw this diagram for each data instance
+               -- draw this diagram for each plugin instance
                per_instance = true,
-               title = "%H: Packets on %di",
+               title = "%H: Packets on %pi",
                vlabel = "Packets/s",
 
                -- diagram data description
--- 
luci/trunk/applications/luci-statistics/luasrc/statistics/rrdtool/definitions/ping.lua
      (revision 9920)
+++ 
luci/trunk/applications/luci-statistics/luasrc/statistics/rrdtool/definitions/ping.lua
      (working copy)
@@ -20,7 +20,7 @@
                -- Ping roundtrip time
                { title = "%H: ICMP Round Trip Time", vlabel = "ms",
                  number_format = "%5.1lf ms", data = {
-                       sources = { ping = { "ping" } },
+                       sources = { ping = { "value" } },
                        options = { ping__ping = { noarea = true, title = "%di" 
} }
                } },
 
_______________________________________________
openwrt-devel mailing list
[email protected]
https://lists.openwrt.org/cgi-bin/mailman/listinfo/openwrt-devel

Reply via email to