the patch should have a description., if the comments on that ticket
explain why the lines should be removed then they will be sufficient.
John
On 31/12/13 14:10, Ant wrote:
Hi,
according to a comment on the ticket:
This compilation failure is a result of commit
fddd8b501c59c87d63a0917c8e9e14bd28e3c724 (upstream commit
6aafeef03b9d9ecf255f3a80ed85ee070260e1ae) in the
linux-stable/linux-3.10.y branch. nfct_reasm is no longer used.
should that comment go in the patch itself?
Antonios
On 31/12/13 13:54, John Crispin wrote:
Hi,
this patch is missing the description. please invest the extra seconds
that it takes to comment what the patch does and why
John
Signed-off-by: Antonios Vamporakis<a...@area128.com>
---
package/kernel/lantiq/ltq-atm/src/ltq_atm.c | 2 --
1 file changed, 2 deletions(-)
diff --git a/package/kernel/lantiq/ltq-atm/src/ltq_atm.c
b/package/kernel/lantiq/ltq-atm/src/ltq_atm.c
index 8466510..15435f6 100644
--- a/package/kernel/lantiq/ltq-atm/src/ltq_atm.c
+++ b/package/kernel/lantiq/ltq-atm/src/ltq_atm.c
@@ -885,8 +885,6 @@ static struct sk_buff*
skb_break_away_from_protocol(struct sk_buff *skb)
#if defined(CONFIG_NF_CONNTRACK) || defined(CONFIG_NF_CONNTRACK_MODULE)
nf_conntrack_put(new_skb->nfct);
new_skb->nfct = NULL;
- nf_conntrack_put_reasm(new_skb->nfct_reasm);
- new_skb->nfct_reasm = NULL;
#ifdef CONFIG_BRIDGE_NETFILTER
nf_bridge_put(new_skb->nf_bridge);
new_skb->nf_bridge = NULL;
_______________________________________________
openwrt-devel mailing list
openwrt-devel@lists.openwrt.org
https://lists.openwrt.org/cgi-bin/mailman/listinfo/openwrt-devel
_______________________________________________
openwrt-devel mailing list
openwrt-devel@lists.openwrt.org
https://lists.openwrt.org/cgi-bin/mailman/listinfo/openwrt-devel
_______________________________________________
openwrt-devel mailing list
openwrt-devel@lists.openwrt.org
https://lists.openwrt.org/cgi-bin/mailman/listinfo/openwrt-devel
