I resend it to the mail list after corrections. Now it's good ?
Thanks a lot. Nabil ----- Mail original ----- De: "Jonas Gorski" <[email protected]> À: "OpenWrt Development List" <[email protected]> Envoyé: Lundi 17 Février 2014 17:35:27 Objet: Re: [OpenWrt-Devel] [PATCH] [packages] ddns services :Please Add dyndns service providers On Mon, Feb 17, 2014 at 4:21 PM, <[email protected]> wrote: > Subject: [PATCH] [packages] ddns services :Please Add dyndns service providers "please" should not be in the subject. The package name is ddns-scripts, not "ddns services". > Adding dyndns service providers (dyndns.fr, dyndnspro.com and > dynamidomain.net). This line is okay, but check the spelling of the domain names. Also you are adding four providers, not three; webdomotic.com is missing from this list. > Hi, could add those please. We need. Give chance for all. Thanks This should not be part of the commit message. > > > Signed-off-by: nabilion (N. Chaniour) <[email protected]> This is not a proper Signed-off-by; it should include your full name and no nicknames. > > Index: packages/net/ddns-scripts/files/usr/lib/ddns/services > =================================================================== > --- packages/net/ddns-scripts/files/usr/lib/ddns/services (revision > 39585) > +++ packages/net/ddns-scripts/files/usr/lib/ddns/services (copie de > travail) > @@ -8,11 +8,22 @@ > # if you need to enter the same text in the url (which seems very unlikely) > put > # that text in lowercase, while the variables should remain in uppercase > > +###Dyndns.fr > +"dyndns.fr" > "http://[DOMAIN]:[PASSWORD]@dyndns.dyndns.fr/update.php?hostname=[DOMAIN]&myip=[IP]"; > +##Dynamicdomain.net > +"dynamicdomain.net" > "http://[DOMAIN]:[PASSWORD]@dyndns.dynamicdomain.net/update.php?hostname=[DOMAIN]&myip=[IP]"; > +####Dyndnspro.com > +"dyndnspro.com" > "http://[DOMAIN]:[PASSWORD]@dyndns.dyndnspro.com/update.php?hostname=[DOMAIN]&myip=[IP]"; > +####"webdomotic" > +"webdomotic.com" > "http://[DOMAIN]:[PASSWORD]@dyndns.webdomotic.com/update.php?hostname=[DOMAIN]&myip=[IP]"; What's up with all these random amount of #? Please use only one. Also, this patch does not apply: patching file net/ddns-scripts/files/usr/lib/ddns/services patch: **** malformed patch at line 38: _______________________________________________ Please fix and resubmit. And don't spam the list with resubmitting the same patch over and over again, sending it once is enough. Regards Jonas _______________________________________________ openwrt-devel mailing list [email protected] https://lists.openwrt.org/cgi-bin/mailman/listinfo/openwrt-devel _______________________________________________ openwrt-devel mailing list [email protected] https://lists.openwrt.org/cgi-bin/mailman/listinfo/openwrt-devel
