Quoting Tim Harvey <[email protected]>:
On Sat, Mar 1, 2014 at 12:37 AM, Hannu Nyman <[email protected]> wrote:
However the thing that bothers me more than 'nut' failing, is the fact
that it is _not_ selected in my .config. What would be causing it to build?
If I uninstall the package (./scripts/feeds uninstall nut) my
build succeeds
fine.
I think that the reason is badly implemented nut support in Luci statistics
(=collectd).
When nut module was re-added to collectd by r34830 in Dec2012, it was not
placed with a conditional dependency on the user's interest for nut support,
instead the nut support gets always built in and apparently requires the
underlying nut to be built also.
See "nut,nut" at the end of line 286 of
feeds/packages/utils/collectd/Makefile:
$(eval $(call BuildPlugin,nut,UPS monitoring input,nut,nut))
Hannu,
Thank you for figuring that out! I've submitted a patch to make nut
conditional. I'm still not clear how to fix nut so it can find libusb
- there is likely a patch needed to its autoconf files I suppose.
I wonder, for future reference what is the best way to determine what
is causing a package to be built? I grepped DEPENDS from all
Makefiles looking for nut and of course came up empty.
Thanks,
Tim
I have one comment to your patch:
I think that the last item on the line should be:
+PACKAGE_collectd-mod-nut:nut
so that the nut package gets conditionally selected, if
collectd-mod-nut has been selected.
That would match the other similar collectd-mods.
-$(eval $(call BuildPlugin,nut,UPS monitoring input,nut,nut))
+$(eval $(call BuildPlugin,nut,UPS monitoring
input,nut,+PACKAGE_collectd-mod-nut:nut))
_______________________________________________
openwrt-devel mailing list
[email protected]
https://lists.openwrt.org/cgi-bin/mailman/listinfo/openwrt-devel
