NAK, incorrect fix. this patch  fixes the behavior of a script that is
> not even in trunk. jffs2reset on purpose asks for you to press y/N.
> Your patch breaks this behavior.
>
> the correct fix is to pass $@ and then have your script pass -y.

You are right reagrding the arguments. I didn't think properly about the pass-through.

This should fix the default reset button script action that is broken. It calls jffs2reset with "-y", but the current /sbin/jffs2reset calls fs-state without arguments. So, reset action never happens via reset button.
https://dev.openwrt.org/browser/trunk/package/base-files/files/etc/rc.button/reset

Patch v2 attached.

--- package/system/fstools/files/jffs2reset
+++ package/system/fstools/files/jffs2reset
@@ -1,3 +1,3 @@
 #!/bin/sh
 
-fs-state overlay jffs2reset
+fs-state overlay jffs2reset $@
_______________________________________________
openwrt-devel mailing list
[email protected]
https://lists.openwrt.org/cgi-bin/mailman/listinfo/openwrt-devel

Reply via email to