Hi Michael,
On 04/06/14 00:01, Florian Fainelli wrote:
Hi Michael,
2014-06-03 14:50 GMT-07:00 Michael Heimpold <[email protected]>:
Hi all,
"recently", the PKG_LICENSE field was introduced in commit
https://dev.openwrt.org/changeset/33861
I really like the approach to add such license information to each
package, so that generating license clearing reports is easy.
The original commit author does not mention any rules about this new field,
or at least I did not found anything in commit history and wiki.
So adding this field to other/new packages involves looking at existing
packages and then copy&paste, or entering this information manually,
which could result in different spellings of the same license.
I recommend that we agree to use a defined standard, e.g.
use the existing "license identifiers" of the SPDX project:
http://spdx.org/licenses/
When a package is covered by more than one license, we should
list them separated by a whitespace character, as is already common practise.
Here is the output of a grep -r 'PKG_LICENSE:='
package/libs/gettext/Makefile:PKG_LICENSE:=FREE
package/libs/ncurses/Makefile:PKG_LICENSE:=FREE
package/libs/zlib/Makefile:PKG_LICENSE:=ZLIB
package/libs/librpc/Makefile:PKG_LICENSE:=GPLv2 LGPLv2.1
package/libs/ustream-ssl/Makefile:PKG_LICENSE:=ISC
package/libs/uclient/Makefile:PKG_LICENSE:=ISC
package/libs/libtool/Makefile:PKG_LICENSE:=GPLv2
package/libs/libbsd/Makefile:PKG_LICENSE:=BSD-4c
package/libs/libubox/Makefile:PKG_LICENSE:=ISC BSD-3c
package/libs/sysfsutils/Makefile:PKG_LICENSE:=GPLv2 LGPLv2.1
package/libs/libreadline/Makefile:PKG_LICENSE:=GPLv3
package/libs/ocf-crypto-headers/Makefile:PKG_LICENSE:=GPLv2
package/libs/libnl-tiny/Makefile:PKG_LICENSE:=GPLv2 LGPLv2.1
package/libs/openssl/Makefile:PKG_LICENSE:=SSLEAY OPENSSL
package/libs/libiconv/Makefile:PKG_LICENSE:=FREE
package/libs/libjson-c/Makefile:PKG_LICENSE:=MIT
package/utils/usbmode/Makefile:PKG_LICENSE:=GPLv2
package/utils/util-linux/Makefile:PKG_LICENSE:=GPLv2 LGPLv2.1 BSD-3c
package/utils/lua/Makefile:PKG_LICENSE:=MIT
package/utils/ubi-utils/Makefile:PKG_LICENSE:=GPLv2
package/utils/fuse/Makefile:PKG_LICENSE:=LGPLv2.1 GPLv2
package/utils/busybox/Makefile:PKG_LICENSE:=GPLv2 BSD-4c
package/network/services/ipset-dns/Makefile:PKG_LICENSE:=GPLv2
package/network/services/dnsmasq/Makefile:PKG_LICENSE:=GPLv2
package/network/services/dropbear/Makefile:PKG_LICENSE:=MIT
package/network/services/samba36/Makefile:PKG_LICENSE:=GPLv3
package/network/utils/uqmi/Makefile:PKG_LICENSE:=GPLv2
package/network/config/netifd/Makefile:PKG_LICENSE:=GPLv2
package/kernel/linux/Makefile:PKG_LICENSE:=GPLv2
package/system/rpcd/Makefile:PKG_LICENSE:=ISC
package/system/mtd/Makefile:PKG_LICENSE:=GPLv2 GPLv2+
package/system/ubox/Makefile:PKG_LICENSE:=GPLv2
package/system/uci/Makefile:PKG_LICENSE:=LGPLv2.1 GPLv2
package/system/ubus/Makefile:PKG_LICENSE:=LGPLv2.1
package/system/procd/Makefile:PKG_LICENSE:=GPLv2
package/system/opkg/Makefile:PKG_LICENSE:=GPLv2
package/system/fstools/Makefile:PKG_LICENSE:=GPLv2
package/boot/kobs-ng/Makefile:PKG_LICENSE:=GPLv2
I would also suggest to make this field mandatory for all new packages
added to the new "rebooted" package feed.
What do you think about?
This looks good to me, could you submit the patch doing this cleanup?
I originally made that commit and at the time of commit I also mentioned
that a parse script would follow. I actually did write a parsing script
in Python, but at the time I did that work it was decided that it would
be better for that script to be written in bash so that the build system
would not depend upon having python installed so I never contributed
that script. I have spoken to the company I was working for at the time
and I expect them to provide me the python script which I will then
re-write in bash and use other available text processing tools to
provide licensing information.
I think using the SPDX license identifiers is an excellent idea, by the way.
Cheers
Hamish
_______________________________________________
openwrt-devel mailing list
[email protected]
https://lists.openwrt.org/cgi-bin/mailman/listinfo/openwrt-devel
