On 2014-06-26 14:09, Dirk Neukirchen wrote: > On 26.06.2014 11:24, Felix Fietkau wrote: >> On 2014-06-25 11:31, [email protected] wrote: >>> From: Dirk Neukirchen <[email protected]> >>> >>> taken from musl-cross >>> https://github.com/GregorR/musl-cross/blob/master/patches/gcc-4.9.0-musl.diff >>> >>> Signed-off-by: Dirk Neukirchen <[email protected]> >> NACK. That patch file contains multiple patches simply copied into one. >> This usually confuses quilt and other patch related tools. >> >> I just tried to update the 4.8 patch based on an updated one from that >> site, and quilt wasn't able to refresh it without messing it up. >> >> - Felix >> > > What is prefered ? Splitting into multiple patches or > like mac80211/patches/300-pending_work.patch with all "meta text" > at the beginning ? I don't mind either way. I think the update may also affect the ldso path and other things, so it would be a good idea to do the update for all gcc versions, not just 4.9.
Also, I think the part of the patch that handles USE_PT_GNU_EH_FRAME is broken for uClibc (breakage will only show up as an increase in executable binary size) - it defines that symbol only if TARGET_DL_ITERATE_PHDR is set, which for some reason is unset with uClibc. - Felix _______________________________________________ openwrt-devel mailing list [email protected] https://lists.openwrt.org/cgi-bin/mailman/listinfo/openwrt-devel
