Hi Felix, The first patch I submitted was faulty. I forgot to notify the mailinglist about this, my apologies. The problem is the $(subst ",,$(KERNELNAME))" part. For most targets KERNELNAME is defined so the command is expanded to something like "make bzImage modules". But for the targets that do not have KERNELNAME defined (for example, the at91 target) the command is expanded to "make modules". In this case the main image is not compiled anymore, only the modules.
I tried to fix this by first calling make with the KERNELNAME only (or empty, which will build the default kernel image target), and then a second call to make for only modules. An alternative way to fix this is to make sure KERNELNAME is defined for every target, but that requires reworking the target makefiles, and could break 3rd party targets that do not have KERNELNAME defined. Kind regards, Fugro Intersite B.V. Tjalling Hattink Software Development Engineer T +31 (0)70 31 11493 | F +31 (0)70 31 11890 [email protected] | www.fugro.com Dillenburgsingel 69, 2263 HW Leidschendam | P.O. Box 154, 2260 AD Leidschendam, The Netherlands Trade Register nr 34048179 | VAT nr NL005621409B24 > -----Original Message----- > From: openwrt-devel [mailto:[email protected]] On Behalf Of Felix Fietkau > Sent: Sunday, October 05, 2014 19:00 > To: Stam, Michel [FINT]; [email protected] > Subject: Re: [OpenWrt-Devel] [PATCH] include: make sure modules are modposted after initramfs image is > built > > On 2014-10-02 15:33, Michel Stam wrote: > > From: Tjalling Hattink <[email protected]> > > > > Otherwise the modpost steps for individual modules that are compiled > > manually (using make package/<name_of_module>/install) will give > > warning of missing symbols when that module depends other modules. > > > > This is caused by the Module.symvers file not containing any symbols > > anymore of external modules when the initramfs image is built without > > specifically giving the modules target. > > > > Signed-off-by: Tjalling Hattink <[email protected]> > I liked Tjalling's original change better (putting both in the same command line instead of doing a > second $(MAKE) invocation), so I applied that one instead. > > - Felix > _______________________________________________ > openwrt-devel mailing list > [email protected] > https://lists.openwrt.org/cgi-bin/mailman/listinfo/openwrt-devel _______________________________________________ openwrt-devel mailing list [email protected] https://lists.openwrt.org/cgi-bin/mailman/listinfo/openwrt-devel
