Hi all

[As I am not sure Jacob and Obinou (the package's registered maintainer) are the same person (are they?), I am trying to CC to both too...]


We are actually trying migrating from a few-months-old trunk snapshot to the official Barrier Breaker release, and on BB protobuf does not work anymore.

A workaround that got protoc to be copied at the right place (and e.g. allowed CMake to find it) was to go to the host build directory and to do a `make install` from here.
In other words:
        $(MAKE) -C $(HOST_BUILD_DIR) install

AFAICU the problem was introduced in the attached patch by adding explicit host macro definitions:

> @@ -37,7 +37,14 @@ define Package/protobuf/description
>    of its internal RPC protocols and file formats.
>   endef
>
> -CONFIGURE_ARGS += --with-protoc=$(STAGING_DIR_HOST)/bin/protoc
> +define Host/Compile
> +  $(MAKE) -C $(HOST_BUILD_DIR)
> +endef
> +
> +define Host/Install
> +endef
> +
> +CONFIGURE_ARGS += --with-protoc=$(HOST_BUILD_DIR)/src/protoc
>
>   define Build/InstallDev
>    $(INSTALL_DIR) \
>

Did that have to be changed for 2.5.0 (from 2.4.1)? What was the need?


Cheers,
   Guillaume
--
ibw ag software, Aarestrasse 17, CH-5412 Vogelsang, http://www.ibwag.com
Guillaume Déflache, Projektingenieur, Telefon: +41 56 201 07 30


---
Diese E-Mail ist frei von Viren und Malware, denn der avast! Antivirus Schutz 
ist aktiv.
http://www.avast.com
--- Begin Message ---
Signed-off-by: Jacob Siverskog <[email protected]>
---
 libs/protobuf/Makefile | 13 ++++++++++---
 1 file changed, 10 insertions(+), 3 deletions(-)

diff --git a/libs/protobuf/Makefile b/libs/protobuf/Makefile
index 789c924..e5593c2 100644
--- a/libs/protobuf/Makefile
+++ b/libs/protobuf/Makefile
@@ -8,12 +8,12 @@
 include $(TOPDIR)/rules.mk
 
 PKG_NAME:=protobuf
-PKG_VERSION:=2.4.1
+PKG_VERSION:=2.5.0
 PKG_RELEASE:=1
 
 PKG_SOURCE:=$(PKG_NAME)-$(PKG_VERSION).tar.bz2
 PKG_SOURCE_URL:=http://protobuf.googlecode.com/files
-PKG_MD5SUM:=ed436802019c9e1f40cc750eaf78f318
+PKG_MD5SUM:=a72001a9067a4c2c4e0e836d0f92ece4
 
 PKG_BUILD_DEPENDS:=protobuf/host
 
@@ -37,7 +37,14 @@ define Package/protobuf/description
  of its internal RPC protocols and file formats.
 endef
 
-CONFIGURE_ARGS += --with-protoc=$(STAGING_DIR_HOST)/bin/protoc
+define Host/Compile
+       $(MAKE) -C $(HOST_BUILD_DIR)
+endef
+
+define Host/Install
+endef
+
+CONFIGURE_ARGS += --with-protoc=$(HOST_BUILD_DIR)/src/protoc
 
 define Build/InstallDev
        $(INSTALL_DIR) \
-- 
1.8.3.2

--- End Message ---
_______________________________________________
openwrt-devel mailing list
[email protected]
https://lists.openwrt.org/cgi-bin/mailman/listinfo/openwrt-devel

Reply via email to