miniupnpd service was always disabled after firmware upgrade.  Original luci 
default logic
was 'enable miniupnpd and if that succeeds, stop and then disable the service'. 
 It should be
'enable miniupnpd and if that fails, stop & disable the service'.

Signed-off-by: Kevin Darbyshire-Bryant <ke...@darbyshire-bryant.me.uk>


diff --git a/applications/luci-app-upnp/root/etc/uci-defaults/luci-upnp 
b/applications/luci-app-upnp/root/etc/uci-defaults/luci-upnp
index fe22a3e..4c45f3c 100755
--- a/applications/luci-app-upnp/root/etc/uci-defaults/luci-upnp
+++ b/applications/luci-app-upnp/root/etc/uci-defaults/luci-upnp
@@ -1,6 +1,6 @@
 #!/bin/sh
 
-/etc/init.d/miniupnpd enabled && {
+/etc/init.d/miniupnpd enabled || {
     /etc/init.d/miniupnpd stop
     /etc/init.d/miniupnpd disable
 }


Attachment: smime.p7s
Description: S/MIME Cryptographic Signature

_______________________________________________
openwrt-devel mailing list
openwrt-devel@lists.openwrt.org
https://lists.openwrt.org/cgi-bin/mailman/listinfo/openwrt-devel

Reply via email to