On 2015-05-11 01:12, Thomas Strobel wrote: > Changing the scripts in OpenWRT to use /usr/bin/env sounds like a > pragmatic choice that would already make life easier under NixOS. > > In addition to changing the scripts, what do you think about referring > to $(STAGING_DIR)/host/bin only for calling host binaries from OpenWRT > scripts? > That is, for calling "perl", the change would be: > > -FEEDS_AVAILABLE:=$(shell $(SCRIPT_DIR)/feeds list -n) > +FEEDS_AVAILABLE:=$($(STAGING_DIR)/host/bin/perl $(SCRIPT_DIR)/feeds list -n) > > I know that this is very similar to what I proposed before, but it would > have the benefit that there is a clear interface through which OpenWRT > accesses any host binaries. I think if $(SCRIPT_DIR)/feeds is changed in a way that it can be called directly, the above change becomes completely pointless, as it only adds redundant information about what format $(SCRIPT_DIR)/feeds is supposed to be. So NACK from me on this one.
> Package-internal builds could be restricted to only access the host > environment through $(STAGING_DIR)/host/bin as well, maybe helping to > execute correctly once all requirements in $(STAGING_DIR)/host/bin are > filled. Right now we rely on many things outside of the staging dir - basic utilties, toolchain, etc. I don't see that changing any time soon. - Felix _______________________________________________ openwrt-devel mailing list [email protected] https://lists.openwrt.org/cgi-bin/mailman/listinfo/openwrt-devel
