On 2015-06-12 21:36, Stefan Rompf wrote: > This patch adds a "channel set helper" callback to the ath9k driver and > exports the ath9k kernel API for other packages. The registered function > is called whenever ath9k changes the channel. > > Signed-off-by: Stefan Rompf <[email protected]> NACK from me for the ath9k_set_channel_helper part. This helper function needs to be passed in from the platform data, similar to how external reset is handled. >From previous emails you pointed out that you guys chose this design/structure simply because you want to have an easy way of debugging, but I think that's not a strong enough reason to make the API between ath9k and the HSR code this quirky.
Here's what I want: The hsr filter code function is passed in by the mach-* function for the UniFi Outdoor, and the code is in the kernel itself. And here's how you make debugging easy: You make a package (which can live somewhere in a separate git tree), which contains a copy of the code that is also in the kernel, and when this package gets loaded, it looks up the ath9k pci device and the platform data, and it overwrites the channel helper function callback. Whenever you're finished testing your changes, you simply copy them back to the source file used by the kernel and submit patches based on that. Does that seem like a reasonable compromise to you? - Felix _______________________________________________ openwrt-devel mailing list [email protected] https://lists.openwrt.org/cgi-bin/mailman/listinfo/openwrt-devel
