> -----Original Message----- > From: Felix Fietkau [mailto:[email protected]] > Sent: Wednesday, July 08, 2015 2:35 PM > To: Guenther Kelleter; [email protected] > Subject: Re: [OpenWrt-Devel] [PATCH v2 6/8] generic: replace request_irq by > request_threaded_irq to fix non working ledtrig-gpio > > On 2015-07-07 11:48, Guenther Kelleter wrote: > >> -----Original Message----- > >> From: Felix Fietkau [mailto:[email protected]] > >> Sent: Monday, July 06, 2015 3:00 PM > >> To: Guenther Kelleter; [email protected] > >> Subject: Re: [OpenWrt-Devel] [PATCH v2 6/8] generic: replace > >> request_irq by request_threaded_irq to fix non working ledtrig-gpio > >> > >> On 2015-07-06 14:14, Guenther Kelleter wrote: > >> > > >> >> -----Original Message----- > >> >> From: Felix Fietkau [mailto:[email protected]] > >> >> Sent: Monday, July 06, 2015 12:43 PM > >> >> To: Guenther Kelleter; [email protected] > >> >> Subject: Re: [OpenWrt-Devel] [PATCH v2 6/8] generic: replace > >> >> request_irq by request_threaded_irq to fix non working > >> >> ledtrig-gpio > >> >> > >> >> On 2015-07-02 13:47, Günther Kelleter wrote: > >> >> > Signed-off-by: Günther Kelleter <[email protected]> > >> >> What issue does this fix? > >> >> > >> >> - Felix > >> > > >> > Without this change, gpio_trig_gpio_store() throws this error: > >> > [ 88.540000] leds devolo:status:dlan: request_irq failed with error -22 > >> > [ 88.550000] leds devolo:error:dlan: request_irq failed with error -22 > >> If you rework the GPIO IRQ handler code to not require threading, you > >> probably won't have to change this generic code. > >> > >> - Felix > > > > I don't see how I could rework this. It fails because of nested interrupt > handlers. > > Someone already tried to solve this issue on lkml > > http://lkml.iu.edu/hypermail/linux/kernel/1409.1/00930.html > > but this also requires generic code changes. > Do you really need to use a threaded IRQ for the nested interrupt handler for > GPIO? > Can't you change the ar71xx GPIO patch to use request_irq instead and drop the > irq_set_nested_thread part? > > - Felix
Yes, I did that already and it's still working. PATCH v3 was posted yesterday. But: Not really sure what I'm doing. All those interrupt handling functionality looks really confusing to me... The patches sent yesterday don't apply anymore today. Guess I have to rebase them again. Günther _______________________________________________ openwrt-devel mailing list [email protected] https://lists.openwrt.org/cgi-bin/mailman/listinfo/openwrt-devel
