Hi,
On Wed, Jul 15, 2015 at 7:05 AM, Cezary Jackiewicz
<[email protected]> wrote:
> This patch adds buttons support for Huawei EchoLife HG553.
>
> Signed-off-by: Cezary Jackiewicz <[email protected]>
Generally looks good, but a few nitpicks:
> ---
>
> diff --git a/target/linux/brcm63xx/dts/hg553.dts
> b/target/linux/brcm63xx/dts/hg553.dts
> index 140e2de..fa22403 100644
> --- a/target/linux/brcm63xx/dts/hg553.dts
> +++ b/target/linux/brcm63xx/dts/hg553.dts
> @@ -6,6 +6,25 @@
> model = "Huawei EchoLife HG553";
> compatible = "huawei,hg553", "brcm,bcm6358";
>
> + gpio-keys-polled {
> + compatible = "gpio-keys-polled";
> + #address-cells = <1>;
> + #size-cells = <0>;
> + poll-interval = <20>;
> + debounce-interval = <60>;
> +
> + rfkill {
> + label = "rfkill";
> + gpios = <&gpio0 9 1>;
> + linux,code = <247>;
> + };
Add an empty line here please.
> + reset {
> + label = "reset";
> + gpios = <&gpio1 5 1>;
> + linux,code = <0x198>;
Please decide on either hexadecimal or decimal for the codes.
Regards
Jonas
_______________________________________________
openwrt-devel mailing list
[email protected]
https://lists.openwrt.org/cgi-bin/mailman/listinfo/openwrt-devel
