On Tue, Sep 8, 2015 at 8:07 PM, Drasko DRASKOVIC <drasko.drasko...@gmail.com> wrote: > Hi Karl, > corrected patch re-sent. > > My comments below. > > BR, > Drasko > > On Sat, Aug 8, 2015 at 3:03 AM, Karl Palsson <ka...@tweak.net.au> wrote: >> -----BEGIN PGP SIGNED MESSAGE----- >> Hash: SHA1 >> >> Comments inline... >> >> Drasko DRASKOVIC <drasko.drasko...@gmail.com> wrote: >>> Signed-off-by: Drasko DRASKOVIC <drasko.drasko...@gmail.com> >>> --- >> >> >> Might just be my mail client, but might be yours, did you change >> anything to send this? you seem to have lost all the commit message up >> into the subject? > > Actually, I use `git send-email` directly, exactly to avoid problems > with different mail clients. All my patches are send via git.
I just figured out that `git send-email` will actually expect commit message to have a subject separated by a blank line from the commit message. Reading this helped: http://tbaggery.com/2008/04/19/a-note-about-git-commit-messages.html. Please ignore previous patch - I will re-send one with correctly formatted commit message. BR, Drasko _______________________________________________ openwrt-devel mailing list openwrt-devel@lists.openwrt.org https://lists.openwrt.org/cgi-bin/mailman/listinfo/openwrt-devel