On 2015-11-08 13:07, Russell Senior wrote: >>>>>> "Felix" == Felix Fietkau <[email protected]> writes: > > Felix> On 2015-11-08 07:24, Russell Senior wrote: >>> >>> Reworked from patch by Ben Pfountz <[email protected]> Builds and >>> boots. >>> >>> Signed-off-by: Russell Senior <[email protected]> > Felix> Why do we need a subtarget for APU instead of just running the > Felix> generic one on it? > > It conveniently selects/deselects a bunch of .config options (e.g. sets > an appropriate BAUDRATE, selects USB options). I haven't studied all the > differences closely. I don't see where in the patch it sets the baudrate. Either way, I'm not a big fan of having too many subtargets, and I don't think APU is special enough to get its own.
Having said that, Imre Kaloz (who maintains the x86_64 subtarget) does not really like having extra config options for embedded devices enabled in the x86_64 subtarget. A while back, Felix Kaechele (Cc'd) wanted to add support for a thin client device to that subtarget, and Imre rejected the change. I think a good solution would be to add a new subtarget for 'embedded' 64-bit devices, and using that for the APU device. This subtarget could be useful for Felix' thin clients as well. - Felix _______________________________________________ openwrt-devel mailing list [email protected] https://lists.openwrt.org/cgi-bin/mailman/listinfo/openwrt-devel
