On 05/12/2015 12:04, Vittorio G (VittGam) wrote:
> The failsafe VLAN workaround is not needed on HT-TM02 (RT5350); it actually 
> breaks
> failsafe since this router has only one port and it is 4 and not 0.
> 
> Anyway, it seems that the workaround is still needed for other routers (see
> https://patchwork.ozlabs.org/patch/424017/ for a previous attempt at removal 
> of
> the whole workaround).
> 
> So this patch explicitly whitelists the HT-TM02 from getting the VLAN 
> workaround.
> 
> This makes failsafe work correctly on it via the ethernet port.
> 
> Signed-off-by: Vittorio Gambaletta <[email protected]>
> 
> ---
> 
> Please apply to both trunk and CC.
> 
> --- a/target/linux/ramips/base-files/lib/preinit/07_set_preinit_iface_ramips
> +++ b/target/linux/ramips/base-files/lib/preinit/07_set_preinit_iface_ramips
> @@ -11,7 +11,7 @@ ramips_set_preinit_iface() {
>               swconfig dev rt305x set reset 1
>       fi
>  
> -     if echo $RT3X5X | egrep -q "(RT5350|MT7628|MT7688)"; then
> +     if echo $RT3X5X | egrep -q "(RT5350|MT7628|MT7688)" && [ 
> "$(ramips_board_name)" != "ht-tm02" ]; then
Hi,

hardcoding the board id here is not a good idea. we should rather use
the board.json data to probe if a switch is registered. if not we dont
apply the hack. i'll ask jow to tell us how to probe for a switch.

        John


>               # This is a dirty hack to get by while the switch
>               # problem is investigated. When VLAN is disabled, ICMP
>               # pings work as expected, but TCP connections time
> _______________________________________________
> openwrt-devel mailing list
> [email protected]
> https://lists.openwrt.org/cgi-bin/mailman/listinfo/openwrt-devel
> 
_______________________________________________
openwrt-devel mailing list
[email protected]
https://lists.openwrt.org/cgi-bin/mailman/listinfo/openwrt-devel

Reply via email to