Hi Felix, On Sun, Jan 03, 2016 at 09:33:13PM +0100, Felix Fietkau wrote: > > - append network_data "phase2=\"$auth\"" > > "$N$T" > > + append network_data > > "phase2=\"auth=$auth\"" "$N$T" > This might break existing configurations that already include the auth= > part, so when reworking this part you should detect and fix this. > Also, for EAP-TLS, phase2 needs to be autheap=TLS, which is not > supported with this change.
Right... Probably this should be changed in LuCI then, because currently $auth is set to values like 'PAP', 'MSCHAPV2', ... see https://github.com/openwrt/luci/blob/master/modules/luci-mod-admin-full/luasrc/model/cbi/admin_network/wifi.lua#L897 which still matches the pre-netifd behaviour as defined in https://dev.openwrt.org/browser/trunk/package/network/services/hostapd/files/wpa_supplicant.sh#L107 which is what I wanted to restore. Having a complex value stored in UCI and leaving it to the user/view to set it seems a bit odd to me (but might still be the best thing to do), maybe we should rather store eap_type in UCI as well and then generate the phase2 string in netifd.sh according to that...? Let me know what you think and I'll suggest a follow-up patch. Cheers Daniel _______________________________________________ openwrt-devel mailing list [email protected] https://lists.openwrt.org/cgi-bin/mailman/listinfo/openwrt-devel
