Felix, Would it be unreasonable to have overridable defaults like suggested in metadata.pl? Convention over configuration and all that.
Eric On Mon, Jan 11, 2016 at 7:35 AM, Felix Fietkau <[email protected]> wrote: > On 2016-01-11 06:16, [email protected] wrote: > > From: Daniel Dickinson <[email protected]> > > > > Certain platforms have large numbers of possible images, and it can be > > desirable to build neither all images nor only a single image, > > therefore this patch makes selecting target profiles a menu instead of a > > single choice, which allows the user to build a specific subset of all > > possible images for a target. > > > > Signed-off-by: Daniel Dickinson <[email protected]> > > --- > > scripts/metadata.pl | 32 +++++++++++++++++++++++++++++--- > > 1 file changed, 29 insertions(+), 3 deletions(-) > > > > diff --git a/scripts/metadata.pl b/scripts/metadata.pl > > index 48b1b7a..4487d26 100755 > > --- a/scripts/metadata.pl > > +++ b/scripts/metadata.pl > > @@ -275,8 +275,7 @@ EOF > > print <<EOF; > > endchoice > > > > -choice > > - prompt "Target Profile" > > +menu "Target Profile" > > > > EOF > > > > @@ -288,8 +287,35 @@ EOF > > config TARGET_$target->{conf}_$profile->{id} > > bool "$profile->{name}" > > depends on TARGET_$target->{conf} > > +EOF > > + > > + if (not (($profile->{id} eq 'Default') || > ($profile->{id} eq 'Minimal'))) { > > + print <<EOF; > > + default y if TARGET_$target->{conf}_Default > > + default n if TARGET_$target->{conf}_Minimal > > +EOF > I like the idea of allowing the user to select multiple profiles. > However, there also needs to be a clean and simple way to select a > single profile without going through the list and deselecting everything. > Also, I don't like hardcoded profile names in metadata.pl, a better > approach would be to have a flag as part of a profile that indicates > that it's not a device profile. > > - Felix > _______________________________________________ > openwrt-devel mailing list > [email protected] > https://lists.openwrt.org/cgi-bin/mailman/listinfo/openwrt-devel > -- Eric Schultz, Community Manager, prpl Foundation http://www.prplfoundation.org [email protected] cell: 920-539-0404 skype: ericschultzwi @EricPrpl
_______________________________________________ openwrt-devel mailing list [email protected] https://lists.openwrt.org/cgi-bin/mailman/listinfo/openwrt-devel
