* amine ahd <amine....@gmail.com> [12.01.2016 10:08]:
> +     [ "$use_dhcp" = 1 ] && {
> +             if [ -z "$dhcp_ifaces" ]; then
> +                     local dump=$(ubus call network.interface dump)
> +                     ntpservers=$(jsonfilter -s "$dump" -e 
> '$["interface"][*]["data"]["ntpserver"]')

please make 'ntpservers' once local in the function head

> +             else
> +                     for iface in $dhcp_ifaces; do
> +                             local status=$(ubus call 
> network.interface.$iface status)
> +                             local ntpserver=$(jsonfilter -s "$status" -e 
> '$["data"]["ntpserver"]')
> +                             [ -n "$ntpserver" ] && \\

this is one '\' to much

> +is_valid_interface() {
> +     local list=$(uci get system.ntp.dhcp_ifaces)

just for me: use list="$( ... )"

bye,bastian
_______________________________________________
openwrt-devel mailing list
openwrt-devel@lists.openwrt.org
https://lists.openwrt.org/cgi-bin/mailman/listinfo/openwrt-devel

Reply via email to