On Sat, 30 Jan 2016 19:05:37 +0100 Hartmut Knaack <[email protected]> wrote:
> -----BEGIN PGP SIGNED MESSAGE----- > Hash: SHA256 > > Michal schrieb am 27.01.2016 um 01:33: > > From: Michal Cieslakiewicz <[email protected]> > > > > Enable platform-supplied WLAN LED name for ath9k device. > > > > Signed-off-by: Michal Cieslakiewicz <[email protected]> > Acked-by: Hartmut Knaack <[email protected]> > > --- > > Looking good overall. I also used this patch series to build > images for the WPN824N to test button support, connected via > the AR9285 GPIOs - no complains. > One very minor detail about the patch subject: it would be > good to prefix even with mac80211: ath9k: enable platform... > It is also good practice to add a description and your > Signed-off-by to the package patches. Many people don't seem > to have done this, as well, but it makes life easier for the > one who will eventually send these patches upstream. > Hello Hartmut, Formal question: does "description and signing package patches" means including filled cover letter (from git-format-patch) as sort of preamble to all 8 patches or should I modify heading comments in patched files themselves ? Regards Michal _______________________________________________ openwrt-devel mailing list [email protected] https://lists.openwrt.org/cgi-bin/mailman/listinfo/openwrt-devel
