Hi Sergey, Sorry for this late (!) reply, I totally missed this patch.
On 2 December 2015 at 15:48, Sergey Shatunov <[email protected]> wrote: > From: Prototik <[email protected]> It doesn't really matter for our svn repo, but please don't try hiding your real name. > Changes since v2: > LED default state modified We usually put comments about version changes in a comment block of a patch. Such comment don't have any real meaning when just browsing repo history. > +--- /dev/null > ++++ b/arch/arm/boot/dts/bcm4708-huawei-ws880.dts > +@@ -0,0 +1,94 @@ > ++/* > ++ * Broadcom BCM470X / BCM5301X ARM platform code. > ++ * DTS for Huawei WS880 > ++ * > ++ * Copyright (C) 2015 Sergey Shatunov <[email protected]> > ++ * > ++ * Licensed under the GNU/GPL. See COPYING for details. > ++ */ > ++ > ++/dts-v1/; > ++ > ++#include "bcm4708.dtsi" > ++#include "bcm5301x-nand-cs0-bch8.dtsi" > ++ > ++/ { > ++ compatible = "huawei,ws880", "brcm,bcm4708"; > ++ model = "Huawei WS880 (BCM4708)"; > ++ > ++ chosen { > ++ bootargs = "console=ttyS0,115200"; > ++ }; > ++ > ++ memory { > ++ reg = <0x00000000 0x08000000>; > ++ }; > ++ > ++ leds { > ++ compatible = "gpio-leds"; > ++ > ++ wlan { > ++ label = "bcm53xx:white:wlan"; > ++ gpios = <&chipcommon 0 GPIO_ACTIVE_LOW>; > ++ linux,default-trigger = "default-ffn"; > ++ }; Typo: s/ffn/off/ > ++ nand@18028000 { > ++ nandcs@0 { > ++ nand-ecc-strength = <4>; > ++ }; > ++ }; I'm thinking if it would make more sense to just have something like: bcm5301x-nand-cs0-bch4.dtsi instead of including bch8 and overwriting strength later. Hauke: any comments to the? I think you added bcm5301x-nand-cs0-bch8.dtsi in the first place? Other than that this patch will need to be rebased for 4.4 kernel due to my slow reaction :| _______________________________________________ openwrt-devel mailing list [email protected] https://lists.openwrt.org/cgi-bin/mailman/listinfo/openwrt-devel
