Hi Antonio,

Comments inline.

Antonio Quartulli wrote:
TODO: hostapd does not work yet with r8188eu

Signed-off-by: Antonio Quartulli <a...@unstable.cc>
---
 package/boot/uboot-sunxi/Makefile            |  8 +++++++-
Can you please split this into a series, and put the packages and the target-related changes into separate patches?

 target/linux/sunxi/config-4.4                | 15 ++++++++++++++-
 target/linux/sunxi/image/Makefile            |  4 ++++
 target/linux/sunxi/profiles/orangepi_mini.mk | 19 +++++++++++++++++++
 4 files changed, 44 insertions(+), 2 deletions(-)
 create mode 100644 target/linux/sunxi/profiles/orangepi_mini.mk

diff --git a/package/boot/uboot-sunxi/Makefile 
b/package/boot/uboot-sunxi/Makefile
index 8844c89..6faac2c 100644
--- a/package/boot/uboot-sunxi/Makefile
+++ b/package/boot/uboot-sunxi/Makefile
[snip]

--- a/target/linux/sunxi/config-4.4
+++ b/target/linux/sunxi/config-4.4
[snip]

+CONFIG_R8188EU=m
I have to slightly disagree here. The pcduino3 profile puts this into a module (kmod-net-rtl8188eu), what was the reason for not following that?

 CONFIG_RATIONAL=y
 # CONFIG_RCU_BOOST is not set
 CONFIG_RCU_STALL_COMMON=y
@@ -435,7 +448,6 @@ CONFIG_SPI_MASTER=y
 CONFIG_SPI_SUN4I=y
 CONFIG_SPI_SUN6I=y
 CONFIG_SRCU=y
-# CONFIG_STAGING is not set
 CONFIG_STMMAC_ETH=y
 CONFIG_STMMAC_PLATFORM=y
 CONFIG_STRICT_DEVMEM=y
@@ -492,6 +504,7 @@ CONFIG_VT_CONSOLE=y
 CONFIG_VT_CONSOLE_SLEEP=y
 CONFIG_VT_HW_CONSOLE_BINDING=y
 CONFIG_WATCHDOG_CORE=y
+# CONFIG_WILC1000_DRIVER is not set
 # CONFIG_WQ_POWER_EFFICIENT_DEFAULT is not set
Just nitpicking, can you add these as a missing symbol into target/linux/generic/config-4.4 in the series?

 CONFIG_XFRM_ALGO=y
 CONFIG_XFRM_USER=y
diff --git a/target/linux/sunxi/image/Makefile 
b/target/linux/sunxi/image/Makefile
index bda690e..190cf02 100644
--- a/target/linux/sunxi/image/Makefile
+++ b/target/linux/sunxi/image/Makefile
@@ -111,6 +111,10 @@ define Image/Build/Profile/orangepi_plus
        $(call Image/Build/SDCard,$(1),sun8i-h3-orangepi-plus)
 endef
+define Image/Build/Profile/Orangepi_mini
+       $(call Image/Build/SDCard,$(1),sun7i-a20-orangepi-mini)
+endef
+
 define Image/Build
        $(call Image/Build/$(1),$(1))
        $(call Image/Build/Profile/$(PROFILE),$(1))
diff --git a/target/linux/sunxi/profiles/orangepi_mini.mk 
b/target/linux/sunxi/profiles/orangepi_mini.mk
new file mode 100644
index 0000000..2d55acf
--- /dev/null
+++ b/target/linux/sunxi/profiles/orangepi_mini.mk
@@ -0,0 +1,19 @@
+#
+# Copyright (C) 2016 OpenWrt.org
+#
+# This is free software, licensed under the GNU General Public License v2.
+# See /LICENSE for more information.
+#
+
+define Profile/Orangepi_mini
+       NAME:=Orangepi_mini
+       PACKAGES:=\
+               uboot-sunxi-Orangepi_mini kmod-ata-core kmod-ata-sunxi \
+               kmod-rtc-sunxi kmod-mac80211 kmod-net-rtl8188eu
+endef
Hmm. Can you please revisit the 8188 module then. :)

+
+define Profile/Orange Pi Mini/Description
+       Package set optimized for the Xunlong Orange Pi Mini
+endef
+
+$(eval $(call Profile,Orangepi_mini))

Thanks,
Zoltan H
_______________________________________________
openwrt-devel mailing list
openwrt-devel@lists.openwrt.org
https://lists.openwrt.org/cgi-bin/mailman/listinfo/openwrt-devel

Reply via email to