I did not try to think through if this would be the correct thing to do for all packages, but the basic change seems reasonable. Having the uci-defaults run postponed to the reboot is annoying in some cases.

However, your patch seems to break the basic characteristics of an uci-defaults script: The script should be deleted only after being run successfully. I think that your patch always deletes the script file, even if it fails.

+               ( . "$i" )
+               rm "$i"


The original uci-defaults run code deletes the file only after evaluating the return value:
https://dev.openwrt.org/browser/trunk/package/base-files/files/etc/init.d/boot#L15
( . "./$(basename $file)" ) && rm -f "$file"
_______________________________________________
openwrt-devel mailing list
[email protected]
https://lists.openwrt.org/cgi-bin/mailman/listinfo/openwrt-devel

Reply via email to