Hi Rafał, On Wed, Sep 28, 2016 at 12:56:27AM +0200, Rafał Miłecki wrote: > On 28 September 2016 at 00:37, Luka Perkov <[email protected]> wrote: > > On Mon, Sep 26, 2016 at 07:59:30AM +0200, Rafał Miłecki wrote: > >> From: Rafał Miłecki <[email protected]> > >> > >> To have service working nicely with procd it should be running in the > >> foreground. Otherwise it's not possible to e.g. stop it with the init.d > >> script. Luckily for us pptpd has a simple switch that allows it. > >> > >> Signed-off-by: Rafał Miłecki <[email protected]> > >> Fixes: 15e7f611afb ("pptpd: convert init script to procd") > >> --- > >> Hi Luka, > >> > >> This pptpd package with broken procd compatibility has been also backported > >> to the for-15.05 branch. Can you apply this fix to for-15.05 as well, > >> please? > > > > Thank you for the patch. We are using for quite a while GitHub pull > > request workflow for all packages in the feeds. Please take a look at > > the documentation: > > > > https://github.com/openwrt/packages/blob/master/CONTRIBUTING.md > > > > That said, can you make a pull request? > > I'm not really comfortable using that proprietary service and its > terrible UI.
Have you maybe changed your mind since the last time [1] you made commit there? > Could you consider accepting this e-mail submitted patch? > You could trivially apply it with a single command: > curl https://patchwork.ozlabs.org/patch/674965/mbox/ | git am In any case I am okay with the patch, feel free to add my Acked-by and push it in the tree. Acked-by: Luka Perkov <[email protected]> Thanks, Luka [1] https://github.com/openwrt/packages/commit/2872ed64cc609f8449de3529f3e6db66151aa164 _______________________________________________ openwrt-devel mailing list [email protected] https://lists.openwrt.org/cgi-bin/mailman/listinfo/openwrt-devel
