> On 19 May 2018, at 18:03, Rosen Penev <ros...@gmail.com> wrote:
>
> Makes it easier to copy/paste the hash manually.
>
> Signed-off-by: Rosen Penev <ros...@gmail.com>
> ---
> scripts/download.pl | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/scripts/download.pl b/scripts/download.pl
> index 34fd6a6f0b..4df0224bcc 100755
> --- a/scripts/download.pl
> +++ b/scripts/download.pl
> @@ -168,7 +168,7 @@ sub download
> $sum = $1;
>
> if ($sum ne $file_hash) {
> - print STDERR "Hash of the downloaded file does not
> match (file: $sum, requested: $file_hash) - deleting download.\n";
> + print STDERR "Hash of the downloaded file does not
> match (file: $sum , requested: $file_hash) - deleting download.\n";
> cleanup();
> return;
> }
> --
> 2.17.0
> I hate to bikeshed this - as the comma is now effectively being used as a separator instead of an English language pause, I think a separator character such as ‘/‘ would be preferable. Also don’t forget, a sequence such as: 1) make package/foo/download PKG_HASH=skip 2) make package/foo/check FIXUP=1 will download your package source ignoring the hash and then update the Makefile’s stored HASH with calculated hash for the downloaded file, thus avoiding the need to get involved in cut’n’paste operations. But I do agree the ‘,’ in its current location is a pain :-) Kevin
signature.asc
Description: Message signed with OpenPGP
_______________________________________________ openwrt-devel mailing list openwrt-devel@lists.openwrt.org http://lists.infradead.org/mailman/listinfo/openwrt-devel
