Hello Mathias, > Please use your full name here. Fixed.
> To be honest, I don't like the ar7241_ap99.dtsi filename and I'm not > sure if it really does make sense to use a dtsi here. For instance, > only two of the boards have a usb led and your workaround is to move > the usb led into an extra gpio led node. I prefer to have a complete > gpio-leds in the dts files instead. > The spi node from the dtsi is overwritten by one dts. In that case it > shouldn't be added to dtsi. Instead each dts should have it's own spi > node. > While I love to remove redundant stuff, we need to keep an eye on > maintainability/readability. I would like to ensure that we don't > break something for the boards including the dtsif, we change > something in the dtsi. Sorry, but I had to use the dsti file (I renamed it to an readability name), because it is suitable for three devices and to save space... Like this https://patchwork.ozlabs.org/patch/928529/ (common dtsi for two devices) By the way, what was the spi sdcard - its was my mod, and I deleted it because in the original it is not present. Sorry)))) > Full name here. as well Fixed. > ucidef_add_switch should already set the lan interface. A > ucidef_set_interface_wan "eth1" should be sufficient here. Fixed. By the way, here is used eth0 as wan and eth1 as lan ports. Otherwise it does not work... > The pending https://github.com/openwrt/openwrt/pull/1091 is about to > remove all memory nodes in favour of the automatic memory detection. > Would you please test if the correct of amount of memory is detected > without the node. If so, it can be removed. Memory node was removed. > Please remove the heartbeat trigger. Due to the led-status alias the > led is used for status/diag signaling. Fixed. > Please use a proper tp-link:<colour>:<function> label as well. Fixed. _______________________________________________ openwrt-devel mailing list openwrt-devel@lists.openwrt.org https://lists.openwrt.org/mailman/listinfo/openwrt-devel