Hi Yousong,

this change seems to introduce serious runtime regressions, see
https://bugs.openwrt.org/index.php?do=details&task_id=1621

It seems to be like that script does things even if the tarballs are
already existing locally.

On a slightly related note, I find the name to be too generic. It
implies that it handles all kinds of download tasks but in the end it is
only a Github archive wrapper. Maybe you should rename it to github.py
or similar.

~ Jo

Attachment: signature.asc
Description: OpenPGP digital signature

_______________________________________________
openwrt-devel mailing list
openwrt-devel@lists.openwrt.org
https://lists.openwrt.org/mailman/listinfo/openwrt-devel

Reply via email to