> On 11 Jul 2018, at 10:44, Hannu Nyman <[email protected]> wrote: > > Kevin Darbyshire-Bryant wrote: >> Really not convinced I agree with the "patch 335 removes the whole code >> block where that one line changed in upstream”. > > You are right. > The corresponding addition needs to be done for the lines replacing the > removed lines: > 932 + if (filter && filter->table[0] && > should likely be > 932 + if (filter && filter->table && > matching the change done upstream. > > In my comment I overlooked the part where we add back similar lines :-(
lol - I’m really happy….it turns out I’m not *completely* stupid :-) > > (the refresh patch only notices the need to refresh the upstream lines, but > does not know about out own additions.) Reading patches to patches is….challenging. I wonder if there’s a tool that would make it easier? Sunshine! Kevin
signature.asc
Description: Message signed with OpenPGP
_______________________________________________ openwrt-devel mailing list [email protected] https://lists.openwrt.org/mailman/listinfo/openwrt-devel
