On 2018-07-19 19:52, Mathias Kresin wrote:
2018-07-19 19:26 GMT+02:00 Thibaut VARÈNE <[email protected]>:
faf94d926e2810f895f2a98d4a49ee2fe8f673e8 added "support" for a hacked
device where the original boot loader (routerboot) has been replaced
by u-boot.
Support for this device with stock bootloader is possible (as
evidenced
by support for the RBM33G), and conflicts with this code.
Remove code before release.
Signed-off-by: Thibaut VARÈNE <[email protected]>
FYI, I already NAK'ed the very same patch on github.
I do agree that it can be done better by not requiring the replacement
of the bootloader. Nevertheless, support for this board is already
shipped since LEDE-17.01 and I don't agree to drop support for a board
without providing an alternative/fixed/better image.
Same as with Thibauts other patches, this time I'll leave it up to
someone else to make a call.
Mathias
Indeed, a "Flash-and-Play" solution would be fine. But as replacing the
bootloader and the uboot-config is a thing you think of twice. If you
really want to change the software on this level.
I did it on some devices an all running fine. Of course I copied the
flash,
via the mtd-device, on my hdd, to have a way back. Even this might
require
an external SPI-writer.
As of the "advanced" installation-steps (in contrast to just uploading a
factory.bin), I would leave it up to the user if he accepts the risk of
a broken / incompatible board and to take the option to use this board
by
dropping support.
Sven
_______________________________________________
openwrt-devel mailing list
[email protected]
https://lists.openwrt.org/mailman/listinfo/openwrt-devel
