On 05/28/2018 10:47 AM, Linus Walleij wrote:
> The Realtek SMI family is a set of DSA chips that provide
> switching in routers. This binding just follows the pattern
> set by other switches but with the introduction of an embedded
> irqchip to demux and handle the interrupts fired by the single
> line from the chip.
> 
> This interrupt construction is similar to how we handle
> interrupt controllers inside PCI bridges etc.
> 
> Cc: Antti Seppälä <a.sepp...@gmail.com>
> Cc: Roman Yeryomin <ro...@advem.lv>
> Cc: Colin Leitner <colin.leit...@googlemail.com>
> Cc: Gabor Juhos <juh...@openwrt.org>
> Cc: Florian Fainelli <f.faine...@gmail.com>
> Cc: devicet...@vger.kernel.org
> Signed-off-by: Linus Walleij <linus.wall...@linaro.org>
> ---

> +
> +     mdio {
> +             compatible = "realtek,smi-mdio", "dsa-mdio";

You should drop the "dsa-mdio" compatible string here since it both non
documented and not matched either.

Other than that, this looks great, with that fixed:

Reviewed-by: Florian Fainelli <f.faine...@gmail.com>
-- 
Florian

_______________________________________________
openwrt-devel mailing list
openwrt-devel@lists.openwrt.org
https://lists.openwrt.org/mailman/listinfo/openwrt-devel

Reply via email to